breaking: Control Tower 3.0 support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
stefanwb
changed the title
stefanwb
force-pushed
the
control-tower-3
branch
from
37546f4 to
46c2cbe
Compare
marwinbaumannsbp
previously approved these changes
Jan 2, 2024
stefanwb
force-pushed
the
control-tower-3
branch
2 times, most recently
from
2434ef4 to
2c3aebb
Compare
…g group 'aws-controltower/CloudTrailLogs' into the management account the log metric and alarms in the enrolled account are removed Signed-off-by: Stefan Wessels Beljaars <[email protected]>
stefanwb
force-pushed
the
control-tower-3
branch
from
ce5874e to
13c9d15
Compare
marwinbaumannsbp
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the consolidating of the log group 'aws-controltower/CloudTrailLogs' into the management account the log metric and alarms in the enrolled account are removed.
This is related to schubergphilis/terraform-aws-mcaf-landing-zone#196 and issue schubergphilis/terraform-aws-mcaf-landing-zone#178